Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProcGoalEnv. #30

Merged
merged 6 commits into from
Jun 30, 2020
Merged

Add ProcGoalEnv. #30

merged 6 commits into from
Jun 30, 2020

Conversation

pedrofreire
Copy link
Contributor

No description provided.

@pedrofreire pedrofreire requested review from qxcv and AdamGleave June 27, 2020 19:04
Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings need to be clarified but otherwise LGTM

src/seals/diagnostics/proc_goal.py Outdated Show resolved Hide resolved
src/seals/diagnostics/proc_goal.py Outdated Show resolved Hide resolved
src/seals/diagnostics/proc_goal.py Outdated Show resolved Hide resolved
@@ -118,3 +118,39 @@ def sample_distribution(
def one_hot_encoding(pos: int, size: int) -> np.ndarray:
"""Returns a 1-D hot encoding of a given position and size."""
return np.eye(size)[pos]


def grid_transition_fn(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commented on this before in #23 -- make sure you address those comments and merge the previous PR before this one.

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #30 into master will increase coverage by 3.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #30      +/-   ##
===========================================
+ Coverage   96.44%   100.00%   +3.55%     
===========================================
  Files          21        22       +1     
  Lines         619       643      +24     
===========================================
+ Hits          597       643      +46     
+ Misses         22         0      -22     
Impacted Files Coverage Δ
src/seals/diagnostics/__init__.py 100.00% <100.00%> (ø)
src/seals/diagnostics/proc_goal.py 100.00% <100.00%> (ø)
src/seals/util.py 100.00% <0.00%> (+1.85%) ⬆️
src/seals/diagnostics/sort.py 100.00% <0.00%> (+48.00%) ⬆️
tests/test_util.py 100.00% <0.00%> (+52.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5ae9b...e3cedd6. Read the comment docs.

src/seals/diagnostics/proc_goal.py Outdated Show resolved Hide resolved
src/seals/diagnostics/proc_goal.py Outdated Show resolved Hide resolved
pedrofreire and others added 2 commits June 30, 2020 23:11
@pedrofreire pedrofreire merged commit b1e2506 into master Jun 30, 2020
@pedrofreire pedrofreire deleted the procgoal-1 branch June 30, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants